Update tests checking launch of workspace from gitlab repository with a .devfile.yaml #744
Conversation
artaleks9
requested review from
SDawley,
ibuziuk,
vinokurig and
tolusha
as code owners
artaleks9
requested review from
dmytro-ndp and
SkorikSergey
and removed request for
SDawley
| @@ -25,6 +25,12 @@ export GIT_PROVIDER_URL=${GIT_PROVIDER_URL:-"https://gitlab.com"} | |||
| export PRIVATE_REPO_SSH_URL=${PRIVATE_REPO_SSH_URL:-"[email protected]:chepullreq1/private-repo.git"} | |||
| export PRIVATE_REPO_RAW_PATH_URL=${PRIVATE_REPO_URL:-"https://gitlab.com/chepullreq1/private-repo/-/raw/main/devfile.yaml"} | |||
|
|
|||
| export PUBLIC_REPO_DOT_DEVFILE_URL=${PUBLIC_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/public-repo-dot-devfile.git"} | |||
There was a problem hiding this comment.
Variable name is a little bit confusing to me.
Did you mean something like PUBLIC_REPO_WITH_DOT_DEFILE_URL?
| @@ -25,6 +25,12 @@ export GIT_PROVIDER_URL=${GIT_PROVIDER_URL:-"https://gitlab.com"} | |||
| export PRIVATE_REPO_SSH_URL=${PRIVATE_REPO_SSH_URL:-"[email protected]:chepullreq1/private-repo.git"} | |||
| export PRIVATE_REPO_RAW_PATH_URL=${PRIVATE_REPO_URL:-"https://gitlab.com/chepullreq1/private-repo/-/raw/main/devfile.yaml"} | |||
|
|
|||
| export PUBLIC_REPO_DOT_DEVFILE_URL=${PUBLIC_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/public-repo-dot-devfile.git"} | |||
| export PRIVATE_REPO_DOT_DEVFILE_URL=${PRIVATE_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/private-repo-dot-devfile.git"} | |||
There was a problem hiding this comment.
Variable name is a little bit confusing to me.
Did you mean something like PRIVATE_REPO_WITH_DOT_DEFILE_URL?
| export PUBLIC_REPO_DOT_DEVFILE_URL=${PUBLIC_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/public-repo-dot-devfile.git"} | ||
| export PRIVATE_REPO_DOT_DEVFILE_URL=${PRIVATE_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/private-repo-dot-devfile.git"} | ||
|
|
||
| export PUBLIC_PROJECT_DOT_DEVFILE_NAME=${PUBLIC_PROJECT_DOT_DEVFILE_NAME:-"public-repo-dot-devfile"} |
There was a problem hiding this comment.
Variable name is a little bit confusing to me.
Did you mean something like NAME_OF_PUBLIC_REPO_WITH_DOT_DEFILE?
| export PRIVATE_REPO_DOT_DEVFILE_URL=${PRIVATE_REPO_DOT_DEVFILE_URL:-"https://gitlab.com/chepullreq1/private-repo-dot-devfile.git"} | ||
|
|
||
| export PUBLIC_PROJECT_DOT_DEVFILE_NAME=${PUBLIC_PROJECT_DOT_DEVFILE_NAME:-"public-repo-dot-devfile"} | ||
| export PRIVATE_PROJECT_DOT_DEVFILE_NAME=${PRIVATE_PROJECT_DOT_DEVFILE_NAME:-"private-repo-dot-devfile"} |
There was a problem hiding this comment.
Variable name is a little bit confusing to me.
Did you mean something like NAME_OF_PRIVATE_REPO_WITH_DOT_DEFILE?
.ci/openshift-ci/common.sh
Outdated
| } | ||
|
|
||
| # Test that the repository is cloned when PAT, OAuth or SSH is configured | ||
| # Test that the repository is cloned when a public repositoty, PAT, OAuth or SSH is configured |
There was a problem hiding this comment.
It's not clear what Test that the repository is cloned when a public repository.... is configured means.
There was a problem hiding this comment.
Test that a public repository is cloned with PAT, OAuth or SSH is configured ?
There was a problem hiding this comment.
The annotation is fixed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, dmytro-ndp, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build 3.18 :: server_3.x/374: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8121: Console, Changes, Git Data |
|
Build 3.18 :: push-latest-container-to-quay_3.x/5026: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8198: server : 3.x :: Build 65969802 : quay.io/devspaces/server-rhel8:3.18-13 |
|
Build 3.18 :: update-digests_3.x/8020: Console, Changes, Git Data |
|
Build 3.18 :: server_3.x/374: Upstream sync done; /DS_CI/sync-to-downstream_3.x/8121 triggered |
|
Build 3.18 :: operator-bundle_3.x/3902: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/8123: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8200: devspaces-operator-bundle : 3.x :: Failed in 65970450 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Adds checking launch of workspace from gitlab repository that has .devfile.yaml
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#23255
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.